Issue #140, remove undocumented feature#141
Open
jzuschlag wants to merge 1 commit into
Open
Conversation
Owner
|
This breaks the test case: test_manage_add_property_option (lfs.manage.tests.ManageTestCase) |
Author
|
I don't see any reason in the test code why it should fail. I am using this code for quite some time on a production system (0.7.7) without any problems. You changed the special character to underscore for 0.8, 0.9 and master. I would prefer a more "special" character like '|', if we want to keep that feature. And please, note it in the docs. |
Owner
|
Hi, AFAIR, the test breaks whether it runs in production or not and it should be adapted. Furthermore, I can't see that the special character has been changed in any version branch. If you want to have it documented, please add it to the documentation and send a PR as always. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.